Adjust checksum during unicore command response #40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The NMEA parse is incorrectly throwing out valid responses from the UM980 because the checksum is missing the $. SEMP: Log NMEA command, 0x0023 (35) bytes, bad checksum, received 0x54, computed: 0x70 Buffer: $command,BESTNAVB 1,response: OK*54 By XORing the $ into the 0x70 computed checksum, we correctly allow the response to pass the check.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The NMEA parse is incorrectly throwing out valid responses from the UM980 because the checksum calculation is not including the $ (needed for unicore command responses).
Example valid response from UM980: $command,BESTNAVB 1,response: OK*54
SEMP: Log NMEA command, 0x0023 (35) bytes, bad checksum, received 0x54, computed: 0x70
By XORing the $ into the 0x70 computed checksum, we correctly allow the response to pass the check.